RE: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops

[Aakarsh Jain]

> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: 24 December 2023 21:14
> To: Marek Szyprowski <m.szyprowski@xxxxxxxxxxx>; Andrzej Hajda
> <andrzej.hajda@xxxxxxxxx>; Mauro Carvalho Chehab
> <mchehab@xxxxxxxxxx>
> Cc: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>; linux-fsd@xxxxxxxxxx; linux-
> samsung-soc@xxxxxxxxxxxxxxx; Smitha T Murthy
> <smithatmurthy@xxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; linux-
> media@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Krzysztof Kozlowski
> <krzysztof.kozlowski@xxxxxxxxxx>
> Subject: [PATCH 02/15] media: s5p-mfc: drop unused static s5p_mfc_ops
> 
> File-scope static variable "s5p_mfc_ops" is not read after assignment, thus it
> can be dropped entirely.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
>  drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> index 673962301173..5ba791fa3676 100644
> --- a/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> +++ b/drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr.c
> @@ -14,18 +14,15 @@
>  #include "s5p_mfc_opr_v5.h"
>  #include "s5p_mfc_opr_v6.h"
> 
> -static struct s5p_mfc_hw_ops *s5p_mfc_ops;
> -
>  void s5p_mfc_init_hw_ops(struct s5p_mfc_dev *dev)  {
>  	if (IS_MFCV6_PLUS(dev)) {
> -		s5p_mfc_ops = s5p_mfc_init_hw_ops_v6();
> +		dev->mfc_ops = s5p_mfc_init_hw_ops_v6();
>  		dev->warn_start = S5P_FIMV_ERR_WARNINGS_START_V6;
>  	} else {
> -		s5p_mfc_ops = s5p_mfc_init_hw_ops_v5();
> +		dev->mfc_ops = s5p_mfc_init_hw_ops_v5();
>  		dev->warn_start = S5P_FIMV_ERR_WARNINGS_START;
>  	}
> -	dev->mfc_ops = s5p_mfc_ops;
>  }
> 
>  void s5p_mfc_init_regs(struct s5p_mfc_dev *dev)
> 
> --
> 2.34.1

Reviewed-by: Aakarsh Jain <aakarsh.jain@xxxxxxxxxxx>

Thanks!