Re: [PATCH 0/2] vdpa: Block vq property change in DRIVER_OK

From: Michael S. Tsirkin
Date: Mon Dec 25 2023 - 09:40:32 EST


On Mon, Dec 25, 2023 at 03:42:08PM +0200, Dragos Tatulea wrote:
> This series prevents the change of virtqueue address or state when a
> device is in DRIVER_OK and not suspended. The virtio spec doesn't
> allow changing virtqueue addresses and state in DRIVER_OK, but some devices
> do support this operation when the device is suspended. The series
> leaves the door open for these devices.
>
> The series was suggested while discussing the addition of resumable
> virtuque support in the mlx5_vdpa driver [0].


I am confused. Isn't this also included in
vdpa/mlx5: Add support for resumable vqs

do you now want this merged separately?

> [0] https://lore.kernel.org/virtualization/20231219180858.120898-1-dtatulea@xxxxxxxxxx/T/#m044ddf540d98a6b025f81bffa058ca647a3d013e
>
> Dragos Tatulea (2):
> vdpa: Track device suspended state
> vdpa: Block vq property changes in DRIVER_OK
>
> drivers/vhost/vdpa.c | 23 +++++++++++++++++++++--
> 1 file changed, 21 insertions(+), 2 deletions(-)
>
> --
> 2.43.0