Re: [PATCH 05/13] mm: Introduce vma_pgtable_walk_{begin|end}()

From: Muchun Song
Date: Mon Dec 25 2023 - 01:35:46 EST




> On Dec 19, 2023, at 15:55, peterx@xxxxxxxxxx wrote:
>
> From: Peter Xu <peterx@xxxxxxxxxx>
>
> Introduce per-vma begin()/end() helpers for pgtable walks. This is a
> preparation work to merge hugetlb pgtable walkers with generic mm.
>
> The helpers need to be called before and after a pgtable walk, will start
> to be needed if the pgtable walker code supports hugetlb pages. It's a
> hook point for any type of VMA, but for now only hugetlb uses it to
> stablize the pgtable pages from getting away (due to possible pmd
> unsharing).
>
> Reviewed-by: Christoph Hellwig <hch@xxxxxxxxxxxxx>
> Signed-off-by: Peter Xu <peterx@xxxxxxxxxx>

Reviewed-by: Muchun Song <songmuchun@xxxxxxxxxxxxx>

Thanks.