[PATCH 05/10] clk: ti: One function call less in ti_fapll_synth_setup() after error detection
From: Markus Elfring
Date: Sun Dec 24 2023 - 11:44:34 EST
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
Date: Sun, 24 Dec 2023 14:05:41 +0100
The kfree() function was called in one case by
the ti_fapll_synth_setup() function during error handling
even if the passed variable contained a null pointer.
This issue was detected by using the Coccinelle software.
Thus use another label.
Signed-off-by: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
---
drivers/clk/ti/fapll.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/ti/fapll.c b/drivers/clk/ti/fapll.c
index e9956e3ccd65..d4674ec3d7e9 100644
--- a/drivers/clk/ti/fapll.c
+++ b/drivers/clk/ti/fapll.c
@@ -504,7 +504,7 @@ static struct clk * __init ti_fapll_synth_setup(struct fapll_data *fd,
synth = kzalloc(sizeof(*synth), GFP_KERNEL);
if (!synth)
- goto free;
+ goto free_init;
synth->fd = fd;
synth->index = index;
@@ -524,6 +524,7 @@ static struct clk * __init ti_fapll_synth_setup(struct fapll_data *fd,
free:
kfree(synth);
+free_init:
kfree(init);
return clk;
--
2.43.0