Re: [PATCH v5 15/16] dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string

[Frank Li]

On Sat, Dec 23, 2023 at 07:44:30PM +0100, Krzysztof Kozlowski wrote:
> On 20/12/2023 22:36, Frank Li wrote:
> > Add i.MX95 PCIe "fsl,imx95-pcie-ep" compatible string.
> > Add reg-name: "atu", "dbi2", "dma" and "serdes".
> > 
> > Signed-off-by: Frank Li <Frank.Li@xxxxxxx>
> > ---
> > 
> > Notes:
> >     Change from v1 to v3
> >     - new patches at v3
> > 
> >  .../bindings/pci/fsl,imx6q-pcie-ep.yaml       | 52 ++++++++++++++++---
> >  1 file changed, 44 insertions(+), 8 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > index ee155ed5f1811..be9ea77ce8548 100644
> > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-ep.yaml
> > @@ -22,14 +22,7 @@ properties:
> >        - fsl,imx8mm-pcie-ep
> >        - fsl,imx8mq-pcie-ep
> >        - fsl,imx8mp-pcie-ep
> > -
> > -  reg:
> > -    minItems: 2
> > -
> > -  reg-names:
> > -    items:
> > -      - const: dbi
> > -      - const: addr_space
> 
> No, why? Entries should be defined top-level. If you remove them here,
> where are they defined (in which schema)?

See: pci/snps,dw-pcie.yaml

> 
> 
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          enum:
> > +            - fsl,imx95-pcie-ep
> > +    then:
> > +      properties:
> > +        linux,pci-domain: true
> 
> Why? It is allowed already.

Sorry, I suppose it should be required. I will fix it.

> 
> 
> Best regards,
> Krzysztof
>