Re: [PATCH v5 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check

[Frank Li]

On Sat, Dec 23, 2023 at 07:42:12PM +0100, Krzysztof Kozlowski wrote:
> On 20/12/2023 22:36, Frank Li wrote:
> > There are clocks and clock-names restriction for difference compatible
> > string. So needn't irrationality check again for clock's miniItems and
> > maxItems.
> 
> That's not really true. Other entry does not restrict clocks and leave
> items quite flexible. These entries should be combined so all
> constraints are fixed for all variants.

There are 7 compatible string at pci/fsl,imx6q-pcie.yaml 

- fsl,imx6q-pcie                                                     
      - fsl,imx6sx-pcie                                                    
      - fsl,imx6qp-pcie                                                    
      - fsl,imx7d-pcie                                                     
      - fsl,imx8mq-pcie                                                    
      - fsl,imx8mm-pcie                                                    
      - fsl,imx8mp-pcie                                                    
      - fsl,imx95-pcie                                                     
                      
All 7 compatible string have check

 - if:                                                                    
      properties:                                                          
        compatible:                                                        
          enum:                                                            
            - fsl,imx6sx-pcie
...
- if:                                                                    
      properties:                                                          
        compatible:                                                        
          enum:                                                            
            - fsl,imx8mq-pcie

...
- if:                                                                    
      properties:                                                          
        compatible:                                                        
          enum:                                                            
            - fsl,imx6q-pcie                                               
            - fsl,imx6qp-pcie                                              
            - fsl,imx7d-pcie
...
  - if:                                                                    
      properties:                                                          
        compatible:                                                        
          enum:                                                            
            - fsl,imx8mm-pcie                                              
            - fsl,imx8mp-pcie
...

This check was not necessary at all. 

> 
> Best regards,
> Krzysztof
>