Re: [PATCH] Documentation/trace: Fixed typos in the ftrace FLAGS section

From: Randy Dunlap
Date: Sat Dec 23 2023 - 14:30:32 EST




On 12/23/23 10:58, Matthew Cassell wrote:
> Fixed typos in the FTRACE_OPS_FL_RECURSION flag description.
>
> Signed-off-by: Matthew Cassell <mcassell411@xxxxxxxxx>

Reviewed-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>

Thanks.

> ---
> Documentation/trace/ftrace-uses.rst | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/trace/ftrace-uses.rst b/Documentation/trace/ftrace-uses.rst
> index f7d98ae5b885..e198854ace79 100644
> --- a/Documentation/trace/ftrace-uses.rst
> +++ b/Documentation/trace/ftrace-uses.rst
> @@ -182,7 +182,7 @@ FTRACE_OPS_FL_SAVE_REGS_IF_SUPPORTED
>
> FTRACE_OPS_FL_RECURSION
> By default, it is expected that the callback can handle recursion.
> - But if the callback is not that worried about overehead, then
> + But if the callback is not that worried about overhead, then
> setting this bit will add the recursion protection around the
> callback by calling a helper function that will do the recursion
> protection and only call the callback if it did not recurse.
> @@ -190,7 +190,7 @@ FTRACE_OPS_FL_RECURSION
> Note, if this flag is not set, and recursion does occur, it could
> cause the system to crash, and possibly reboot via a triple fault.
>
> - Not, if this flag is set, then the callback will always be called
> + Note, if this flag is set, then the callback will always be called
> with preemption disabled. If it is not set, then it is possible
> (but not guaranteed) that the callback will be called in
> preemptable context.

--
#Randy
https://people.kernel.org/tglx/notes-about-netiquette
https://subspace.kernel.org/etiquette.html