RE: [EXT] Re: [PATCH net-next v1 4/8] octeon_ep_vf: add Tx/Rx ring resource setup and cleanup

From: Shinas Rasheed
Date: Fri Dec 22 2023 - 11:33:51 EST


> Hi Shinas,
>
> some minor feedback from my side which you might consider addressing
> if you have to respin the series for some other reason.
>
+
> > + oq->buff_info = (struct octep_vf_rx_buffer *)
> > + vzalloc(oq->max_count *
> OCTEP_VF_OQ_RECVBUF_SIZE);
>
> nit: There is no need to cast the return value of vzalloc()
>
> oq->buff_info = vzalloc(oq->max_count *
> OCTEP_VF_OQ_RECVBUF_SIZE);
>>....
> > + if (iq->buff_info)
> > + vfree(iq->buff_info);
>
> nit: vfree can handle a NULL argument, so there is no need to protect it
> with a if condition
>

Thanks for the input. I'll wait for feedback from others a little while longer and then address these in the next version.