Re: [PATCH v2] tracing/selftests: Add ownership modification tests for eventfs

From: Steven Rostedt
Date: Thu Dec 21 2023 - 21:00:57 EST


On Fri, 22 Dec 2023 10:52:00 +0900
Masami Hiramatsu (Google) <mhiramat@xxxxxxxxxx> wrote:

> > +instance="foo-$(mktemp -u XXXXX)"
> >
> > This doesn't work. it needs XXXXXX (6 times X). And this is
> > somewhat wrong usage of mktemp because it can not check there is
> > foo-<random>.
> > What about change it as
> >
> > instance="$(mktemp -u foo-XXXXXX)"

That can work too, although I think I'll change it from "foo" to "test".

> >
> > ?
>
> And I confirmed that this test passed on v6.5.13 with that change.

Thanks, I'll send out a v3 with 6 Xs. ;-)

-- Steve