Re: [PATCH v3 2/2] gpio: sysfs: drop tabs from local variable declarations

From: Andy Shevchenko
Date: Thu Dec 21 2023 - 07:59:29 EST


On Thu, Dec 21, 2023 at 10:15:47AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
>
> Older code has an annoying habit of putting tabs between the type and the
> name of the variable. This doesn't really add to readability and newer
> code doesn't do it so make the entire file consistent.

...

> + long gpio;
> + struct gpio_desc *desc;
> + int status;

Not fully reversed xmas tree order...

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

--
With Best Regards,
Andy Shevchenko