Re: [PATCH 13/17] writeback: Factor writeback_get_folio() out of write_cache_pages()

From: Jan Kara
Date: Thu Dec 21 2023 - 07:33:37 EST


On Thu 21-12-23 13:25:35, Christoph Hellwig wrote:
> On Thu, Dec 21, 2023 at 12:41:53PM +0100, Jan Kara wrote:
> > But I'd note that the call stack depth of similarly called helper functions
> > (with more to come later in the series) is getting a bit confusing. Maybe
> > we should inline writeback_get_next() into its single caller
> > writeback_get_folio() to reduce confusion a bit...
>
> I just hacked that up based on the fully applied series and that looks
> good to me.

Yeah, cleanup on top works for me so that you don't have to rebase.

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR