Re: [RFC nf-next v2 1/2] netfilter: bpf: support prog update

From: D. Wythe
Date: Wed Dec 20 2023 - 07:40:45 EST




On 12/19/23 10:58 PM, Florian Westphal wrote:
D. Wythe <alibuda@xxxxxxxxxxxxxxxxx> wrote:
net/netfilter/nf_bpf_link.c:31:22: note: in expansion of macro
‘rcu_dereference’
   31 |  return bpf_prog_run(rcu_dereference((const struct bpf_prog __rcu
*)nf_link->link.prog), &ctx);
      |                      ^~~~~~~~~~~~~~~

So, I think we might need to go back to version 1.

@ Florian , what do you think ?
Use rcu_dereference_raw().

Got it. I'm also good with that.

D. Wythe