Re: [PATCH v2 2/2] interconnect: qcom: Add MSM8909 interconnect provider driver

[Konrad Dybcio]

On 20.12.2023 11:38, Stephan Gerhold wrote:
> From: Adam Skladowski <a39.skl@xxxxxxxxx>
> 
> Add driver for interconnect busses found in MSM8909 based platforms.
> The topology consists of three NoCs that are partially controlled by
> a RPM processor.
> 
> In the downstream/vendor kernel from Qualcomm there is an additional
> "mm-snoc". However, it actually ends up using the same RPM "snoc_clk"
> as the normal "snoc". It looks like this is actually the same NoC
> in hardware and the "mm-snoc" was only defined to assign a different
> "qcom,util-fact" to increase bandwidth requests by a static margin.
> In mainline we can represent this by assigning the equivalent "ab_coeff"
> to all the nodes that are part of "mm-snoc" downstream.
> 
> Signed-off-by: Adam Skladowski <a39.skl@xxxxxxxxx>
> [Stephan: Drop separate mm-snoc that exists downstream since it's
>  actually the same NoC as SNoC in hardware, add qos_offset for BIMC,
>  add ab_coeff for mm-snoc nodes and BIMC]
> Signed-off-by: Stephan Gerhold <stephan.gerhold@xxxxxxxxxxxxxxx>
> ---
The hard work we put into fixing up smd rpm icc paid off.. thanks!

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>

Konrad