Re: [PATCH v4 2/2] leds: qcom-lpg: Add PM660L configuration and compatible

From: Johan Hovold
Date: Wed Dec 20 2023 - 03:10:09 EST


On Tue, Dec 19, 2023 at 11:06:08AM +0100, Marijn Suijten wrote:
> On 2023-12-19 10:33:25, Johan Hovold wrote:
> > On Tue, Dec 19, 2023 at 10:17:16AM +0100, Marijn Suijten wrote:
> >
> > > Note that I have one more unmerged leds patch around, that hasn't been looked
> > > at either. Would it help to send this once again, perhaps with more reviewers/
> > > testing (Johan, would you mind taking a look too)?
> > >
> > > https://lore.kernel.org/linux-leds/20220719213034.1664056-1-marijn.suijten@xxxxxxxxxxxxxx/
> >
> > Yes, I suggest you resend that one too so that it ends up in Lee's
> > inbox.
>
> I will rebase, test and resend it too. Just asking if you notice any glaring
> issues with this patch, as it won't be the first time it has been resent after
> not being looked at for some time.

I haven't look at this code before and only skimmed it now, but your
patch looks correct to me.

Johan