Re: [PATCH] dt-bindings: soc: xilinx: Add support for K26 rev2 SOMs

From: Krzysztof Kozlowski
Date: Wed Dec 20 2023 - 02:55:46 EST


On 19/12/2023 15:25, Michal Simek wrote:
> Revision 2 is SW compatible with revision 1 but it is necessary to reflect
> it in model and compatible properties which are parsed by user space.
> Rev 2 has improved a power on boot reset and MIO34 shutdown glich
> improvement done via an additional filter in the GreenPak chip.
>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
> ---
>
> Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml b/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
> index d4c0fe1fe435..62617e1ea74f 100644
> --- a/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
> +++ b/Documentation/devicetree/bindings/soc/xilinx/xilinx.yaml
> @@ -118,6 +118,7 @@ properties:
>
> - description: Xilinx Kria SOMs
> items:
> + - const: xlnx,zynqmp-sm-k26-rev2
> - const: xlnx,zynqmp-sm-k26-rev1
> - const: xlnx,zynqmp-sm-k26-revB
> - const: xlnx,zynqmp-sm-k26-revA

You are changing existing list of compatibles, so all devices with
"rev1" will fail the checks. Is it expected?

Best regards,
Krzysztof