Re: [PATCH V2 3/5] nvmem: u-boot-env: use more nvmem subsystem helpers

From: Miquel Raynal
Date: Wed Dec 20 2023 - 02:17:35 EST


Hi Rafał,

zajec5@xxxxxxxxx wrote on Tue, 19 Dec 2023 19:16:37 +0100:

> On 19.12.2023 19:13, Greg Kroah-Hartman wrote:
> > On Tue, Dec 19, 2023 at 06:40:23PM +0100, Rafał Miłecki wrote:
> >> From: Rafał Miłecki <rafal@xxxxxxxxxx>
> >>
> >> 1. Use nvmem_dev_size() and nvmem_device_read() to make this driver less
> >> mtd dependent
> >> 2. Use nvmem_add_one_cell() to simplify adding NVMEM cells
> >
> > Shouldn't this be 2 different patches?
>
> I used to maintainers complaining my patches are too small and not the
> other way ;) I think it happened two or three times with mtd subsys.

A single patch may be too small if it's alone and we don't see the big
picture, otherwise I have no issue with small patches, do I? Anyway, in
this case I don't mind the patch being split or kept like this, just
keep my R-by applied to both if you do indeed split.

Thanks,
Miquèl