Re: [PATCH] cpufreq: intel_pstate: Add Emerald Rapids support in no-HWP mode

[srinivas pandruvada]

On Tue, 2023-12-19 at 21:22 +0100, Rafael J. Wysocki wrote:
> On Wed, Dec 13, 2023 at 11:28 AM Zhenguo Yao <yaozhenguo1@xxxxxxxxx>
> wrote:
> > 
> > Users may disable HWP in firmware, in which case intel_pstate
> > wouldn't load
> > unless the CPU model is explicitly supported.
> > 
> > See also the following past commits:
> > 
> > commit df51f287b5de ("cpufreq: intel_pstate: Add Sapphire Rapids
> > support
> > in no-HWP mode")
> > commit d8de7a44e11f ("cpufreq: intel_pstate: Add Skylake servers
> > support")
> > commit 706c5328851d ("cpufreq: intel_pstate: Add Cometlake support
> > in
> > no-HWP mode")
> > commit fbdc21e9b038 ("cpufreq: intel_pstate: Add Icelake servers
> > support in
> > no-HWP mode")
> > commit 71bb5c82aaae ("cpufreq: intel_pstate: Add Tigerlake support
> > in
> > no-HWP mode")
> > 
> > Signed-off-by: Zhenguo Yao <yaozhenguo1@xxxxxxxxx>
> 
> Srinivas, any objections?
No.

Acked-by: Srinivas Pandruvada <srinivas.pandruvada@xxxxxxxxxxxxxxx>

> 
> > ---
> >  drivers/cpufreq/intel_pstate.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/cpufreq/intel_pstate.c
> > b/drivers/cpufreq/intel_pstate.c
> > index a534a1f7f1ee..39e0a2cf7236 100644
> > --- a/drivers/cpufreq/intel_pstate.c
> > +++ b/drivers/cpufreq/intel_pstate.c
> > @@ -2406,6 +2406,7 @@ static const struct x86_cpu_id
> > intel_pstate_cpu_ids[] = {
> >         X86_MATCH(ICELAKE_X,            core_funcs),
> >         X86_MATCH(TIGERLAKE,            core_funcs),
> >         X86_MATCH(SAPPHIRERAPIDS_X,     core_funcs),
> > +       X86_MATCH(EMERALDRAPIDS_X,      core_funcs),
> >         {}
> >  };
> >  MODULE_DEVICE_TABLE(x86cpu, intel_pstate_cpu_ids);
> > --
> > 2.39.3
> >