Re: [PATCH v11 16/19] KVM: xen: split up kvm_xen_set_evtchn_fast()

From: David Woodhouse
Date: Tue Dec 19 2023 - 11:48:54 EST


On 19 December 2023 16:11:06 GMT, Paul Durrant <paul@xxxxxxx> wrote:
>From: Paul Durrant <pdurrant@xxxxxxxxxx>
>
>The implementation of kvm_xen_set_evtchn_fast() is a rather lengthy piece
>of code that performs two operations: updating of the shared_info
>evtchn_pending mask, and updating of the vcpu_info evtchn_pending_sel
>mask. Introduce a separate function to perform each of those operations and
>re-work kvm_xen_set_evtchn_fast() to use them.
>
>No functional change intended.
>
>Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx

Reviewed-by: <dwmw@xxxxxxxxxxxx>

Would still like to see the xen_shinfo_test use an evtchn port# which triggers the bug in the precious version.