Re: [PATCH] ASoC: dt-bindings: qcom,lpass-va-macro: remove spurious contains in if statement

From: Krzysztof Kozlowski
Date: Tue Dec 19 2023 - 08:44:34 EST


On 19/12/2023 14:23, Neil Armstrong wrote:
> Remove this spurious "contains" which causes the bindings check of
> qcom,sm8450-lpass-va-macro compatible to fail with:
> codec@33f0000: clocks: [[156, 57, 1], [156, 102, 1], [156, 103, 1], [156, 70, 1]] is too long
> from schema $id: http://devicetree.org/schemas/sound/qcom,lpass-va-macro.yaml#
> codec@33f0000: clock-names: ['mclk', 'macro', 'dcodec', 'npl'] is too long
> from schema $id: http://devicetree.org/schemas/sound/qcom,lpass-va-macro.yaml#
>
> Seems the double "contains" was considered as valid by the tool but broke
> the entire if statements.
>
> Fixes: f243ef746d0a ("ASoC: dt-bindings: qcom,lpass-va-macro: Add SM8650 LPASS VA")


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>

Best regards,
Krzysztof