Re: [PATCH v2 2/2] drm/rockchip: rk3066_hdmi: drop custom fill_modes hook

From: Maxime Ripard
Date: Tue Dec 19 2023 - 07:55:35 EST


Hi,

On Mon, Dec 18, 2023 at 04:49:06PM +0100, Johan Jonker wrote:
> CRTC size validation for the display controller has been added with
> Commit 8e140cb60270 ("drm/rockchip: vop: limit maximum resolution to
> hardware capabilities"), so we can drop the custom fill_modes hook.
>
> Signed-off-by: Johan Jonker <jbx6244@xxxxxxxxx>

I'm not sure those two are equivalent. CRTC and connectors usually have
different requirements and capabilities, and thus different,
supplementary, mode_valid/atomic_check implementations.

Maxime

Attachment: signature.asc
Description: PGP signature