Re: [PATCH] efi/libstub: zboot: do not use $(shell ...) in cmd_copy_and_pad

From: Will Deacon
Date: Tue Dec 19 2023 - 06:18:59 EST


On Mon, 18 Dec 2023 17:01:27 +0900, Masahiro Yamada wrote:
> You do not need to use $(shell ...) in recipe lines, as they are already
> executed in a shell. An alternative solution is $$(...), which is an
> escaped sequence of the shell's command substituion, $(...).
>
> For this case, there is a reason to avoid $(shell ...).
>
> Kbuild detects command changes by using the if_changed macro, which
> compares the previous command recorded in .*.cmd with the current
> command from Makefile. If they differ, Kbuild re-runs the build rule.
>
> [...]

Applied to arm64 (for-next/kbuild), thanks!

[1/1] efi/libstub: zboot: do not use $(shell ...) in cmd_copy_and_pad
https://git.kernel.org/arm64/c/97ba4416d6dd

Cheers,
--
Will

https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev