Re: [lvc-project] [PATCH] linux-5.19.y: net: fddi: skfp: Uninitialized data

From: Alexey Khoroshilov
Date: Tue Dec 19 2023 - 04:23:24 EST


Dear Alexander,


On 19.12.2023 12:00, Александр C wrote:
> Uninitialized data is read from local variable 'word_val' at pmf.c:1302.
>
> Found by Linux Verification Center (linuxtesting.org
> <http://linuxtesting.org>) with SVACE.
>
> Signed-off-by: Alexander Sapozhnikov <alsp705@xxxxxxxxx
> <mailto:alsp705@xxxxxxxxx>>
> ---
>  drivers/net/fddi/skfp/pmf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/fddi/skfp/pmf.c b/drivers/net/fddi/skfp/pmf.c
> index 563fb7f0b327..3f24fbd82a73 100644
> --- a/drivers/net/fddi/skfp/pmf.c
> +++ b/drivers/net/fddi/skfp/pmf.c
> @@ -1084,7 +1084,7 @@ static int smt_set_para(struct s_smc *smc, struct
> smt_para *pa, int index,
>   int path ;
>   int port ;
>   SK_LOC_DECL(u_char,byte_val) ;
> - SK_LOC_DECL(u_short,word_val) ;
> + SK_LOC_DECL(u_short, word_val) = 0 ;
>   SK_LOC_DECL(u_long,long_val) ;
>  
>   mac = index - INDEX_MAC ;
> --

Something is broken with your e-mail settings. The mail is in HTML, not
in plain text.

Have you used git send-email to send the patch?

--
Alexey