Re: [PATCH v2 3/3] rust: workqueue: add `#[pin_data]` to `Work`

From: Martin Rodriguez Reboredo
Date: Mon Dec 18 2023 - 15:50:05 EST


On 12/18/23 14:47, Benno Lossin wrote:
On 12/14/23 04:13, Martin Rodriguez Reboredo wrote:
On 12/13/23 19:09, Benno Lossin wrote:
The previous two patches made it possible to add `#[pin_data]` on
structs with default generic parameter values.
This patch makes `Work` use `#[pin_data]` and removes an invocation of
`pin_init_from_closure`. This function is intended as a low level manual
escape hatch, so it is better to rely on the safe `pin_init!` macro.

Signed-off-by: Benno Lossin <benno.lossin@xxxxxxxxx>
---
[...]

Did you mean to add your reviewed by? Because I received only
the quote.


Thunderbird is a disaster for plain-text emails.

Reviewed-by: Martin Rodriguez Reboredo <yakoyoku@xxxxxxxxx>