Re: [PATCH v10 18/41] ALSA: usb-audio: qcom: Add USB QMI definitions

[Wesley Cheng]

Hi Jeff,

On 12/15/2023 2:38 PM, Jeff Johnson wrote:
> On 12/15/2023 1:49 PM, Wesley Cheng wrote:
> > The Qualcomm USB audio offload driver utilizes the QMI protocol to
> > communicate with the audio DSP.  Add the necessary QMI header and field
> > definitions, so the QMI interface driver is able to route the QMI packet
> > received to the USB audio offload driver.
> >
> > Signed-off-by: Wesley Cheng <quic_wcheng@xxxxxxxxxxx>
> > ---
> >   sound/usb/qcom/usb_audio_qmi_v01.c | 892 +++++++++++++++++++++++++++++
> >   sound/usb/qcom/usb_audio_qmi_v01.h | 162 ++++++
> >   2 files changed, 1054 insertions(+)
> >   create mode 100644 sound/usb/qcom/usb_audio_qmi_v01.c
> >   create mode 100644 sound/usb/qcom/usb_audio_qmi_v01.h
> >
> > diff --git a/sound/usb/qcom/usb_audio_qmi_v01.c b/sound/usb/qcom/usb_audio_qmi_v01.c
> > new file mode 100644
> > index 000000000000..bdfd67d980eb
> > --- /dev/null
> > +++ b/sound/usb/qcom/usb_audio_qmi_v01.c
> > @@ -0,0 +1,892 @@
> > +// SPDX-License-Identifier: GPL-2.0
> > +/*
> > + * Copyright (c) 2022-2023 Qualcomm Innovation Center, Inc. All rights reserved.
> > + */
> > +
> > +#include <linux/soc/qcom/qmi.h>
> > +
> > +#include "usb_audio_qmi_v01.h"
> > +
> > +static struct qmi_elem_info mem_info_v01_ei[] = {
>
> I believe all of the struct qmi_elem_info arrays can be const.
>
> At least that was the goal of commit ff6d365898d4 ("soc: qcom: qmi: use
> const for struct qmi_elem_info")

Thanks for the review.  Will fix this.

Thanks
Wesley Cheng