Re: [PATCH v5 1/5] block: Fix bio IO priority setting

From: Henry King
Date: Sun Dec 17 2023 - 20:25:13 EST


Mike Snitzer <snitzer@xxxxxxxxxx> 于2023年12月14日周四 00:58写道:
>
> On Wed, Dec 13 2023 at 5:42P -0500,
> Hongyu Jin <hongyu.jin.cn@xxxxxxxxx> wrote:
>
> > From: Hongyu Jin <hongyu.jin@xxxxxxxxxx>
> >
> > Move bio_set_ioprio() into submit_bio():
> > 1. Only call bio_set_ioprio() once to set the priority of original bio,
> > the bio that cloned and splited from original bio will auto inherit
> > the priority of original bio in clone process.
> >
> > 2. The IO priority can be passed to module that implement
> > struct gendisk::fops::submit_bio, help resolve some
> > of the IO priority loss issues.
> >
> > This patch depends on commit 82b74cac2849 ("blk-ioprio: Convert from
> > rqos policy to direct call")
> >
> > Fixes: a78418e6a04c ("block: Always initialize bio IO priority on submit")
> >
> > Co-developed-by: Yibin Ding <yibin.ding@xxxxxxxxxx>
> > Signed-off-by: Yibin Ding <yibin.ding@xxxxxxxxxx>
> > Signed-off-by: Hongyu Jin <hongyu.jin@xxxxxxxxxx>
>
> Would be nice to get this block core fix upstream ASAP independent of
> your various DM changes.
dm modification depends on block modification to have effect, so it is
reviewed together.
>
> Please simplify this patch's header like was requested in review of v4:
> https://patchwork.kernel.org/project/dm-devel/patch/20231212111150.18155-2-hongyu.jin.cn@xxxxxxxxx/
ok, i will send the header。