Re: PATCH [netfilter] Remove old case sensitive variants of lowercase .c and .h files

From: Jan Engelhardt
Date: Sat Dec 16 2023 - 15:20:04 EST



On Saturday 2023-12-16 20:22, Samuel Marks wrote:

>`git clone` fails on case-insensitive file systems, e.g., on Windows,
>MSYS, Cygwin due to case sensitive files. All but one are in
>netfilter, and they seem to be old code that isn't necessary.
>
> include/uapi/linux/netfilter/xt_CONNMARK.h | 7 -
> include/uapi/linux/netfilter/xt_DSCP.h | 27 --
> include/uapi/linux/netfilter/xt_MARK.h | 7 -
> include/uapi/linux/netfilter/xt_RATEEST.h | 17 -
> include/uapi/linux/netfilter/xt_TCPMSS.h | 13 -
> include/uapi/linux/netfilter_ipv4/ipt_ECN.h | 34 --
> include/uapi/linux/netfilter_ipv4/ipt_TTL.h | 24 --
> include/uapi/linux/netfilter_ipv6/ip6t_HL.h | 25 --
> net/netfilter/Makefile | 4 -
> net/netfilter/xt_DSCP.c | 161 ---------
> net/netfilter/xt_HL.c | 159 ---------
> net/netfilter/xt_RATEEST.c | 233 -------------
> net/netfilter/xt_TCPMSS.c | 345 --------------------
> 13 files changed, 1056 deletions(-)
> delete mode 100644 include/uapi/linux/netfilter/xt_CONNMARK.h
> delete mode 100644 include/uapi/linux/netfilter/xt_DSCP.h
> delete mode 100644 include/uapi/linux/netfilter/xt_MARK.h
> delete mode 100644 include/uapi/linux/netfilter/xt_RATEEST.h
> delete mode 100644 include/uapi/linux/netfilter/xt_TCPMSS.h
> delete mode 100644 include/uapi/linux/netfilter_ipv4/ipt_ECN.h
> delete mode 100644 include/uapi/linux/netfilter_ipv4/ipt_TTL.h
> delete mode 100644 include/uapi/linux/netfilter_ipv6/ip6t_HL.h
> delete mode 100644 net/netfilter/xt_DSCP.c
> delete mode 100644 net/netfilter/xt_HL.c
> delete mode 100644 net/netfilter/xt_RATEEST.c
> delete mode 100644 net/netfilter/xt_TCPMSS.c

Did you ever test this?

iptables -t mangle -A PREROUTING -i xyz0 -p tcp --syn -j TCPMSS --set-mss 1440

will now fail.