Re: [PATCH 09/11] writeback: Factor writeback_iter_next() out of write_cache_pages()

From: Christoph Hellwig
Date: Fri Dec 15 2023 - 23:51:45 EST


On Fri, Dec 15, 2023 at 09:17:05AM -0500, Brian Foster wrote:
> + while ((folio = writeback_get_next(mapping, wbc)) != NULL) {
> wbc->done_index = folio->index;
> folio_lock(folio);
> if (likely(should_writeback_folio(mapping, wbc, folio)))
> break;
> folio_unlock(folio);
> }
>
> + if (folio)
> + trace_wbc_writepage(wbc, inode_to_bdi(mapping->host));
> return folio;

I posted a very similar transformation in reply to willy's first posting
of the series :) I guess that's 2:1 now and I might as well go ahead
and do something like that now :)