Re: [PATCH] Revert "soc: qcom: stats: Add DDR sleep stats"

From: Bjorn Andersson
Date: Fri Dec 15 2023 - 23:35:17 EST


On Sat, Dec 16, 2023 at 01:05:53AM +0100, Konrad Dybcio wrote:
> On 14.12.2023 13:25, Konrad Dybcio wrote:
> > After recent reports ([1], [2]) of older platforms (particularly 8150 and
> > 7180) breaking after DDR sleep stats introduction, revert the following:
> >
> > Commit 73380e2573c3 ("soc: qcom: stats: fix 64-bit division")
> > Commit e84e61bdb97c ("soc: qcom: stats: Add DDR sleep stats")
> >
> > The feature itself is rather useful for debugging DRAM power management,
> > however it looks like the shared RPMh stats data structures differ on
> > previous SoCs.
> >
> > Revert its addition for now to un-break booting on these earlier SoCs,
> > while I try to come up with a better way to enable it conditionally.
> >
> > [1] https://lore.kernel.org/linux-arm-msm/20231209215601.3543895-2-dmitry.baryshkov@xxxxxxxxxx/
> > [2] https://lore.kernel.org/linux-arm-msm/CAD=FV=XX4wLg1NNVL15RK4D4tLvuSzZyUv=k_tS4bSb3=7QJzQ@xxxxxxxxxxxxxx/
> >
> > Reported-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> > Reported-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> > Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> > ---
> Arnd, since Bjorn seems to be MIA, could you please pick this directly
> so that it gets into the next RC? Un-breaking booting on some platforms
> would be very welcome :D
>

I'm confused, the two offending commits are staged for v6.8. Which -rc
do you want this applied in?! And you posted this patch yesterday...

Regards,
Bjorn