Re: [PATCH V2 net-next 2/3] net: hns3: dump more reg info based on ras mod

[Jijie Shao]

on 2023/12/15 16:01, Simon Horman wrote:
> On Thu, Dec 14, 2023 at 10:11:34PM +0800, Jijie Shao wrote:
> >   #include "hclge_main.h"
> > +#include "hclge_debugfs.h"
> Hi Jijie Shao and Peiyang Wang,
>
> hclge_debugfs.h defines a number of constants, such as hclge_dbg_tqp_reg.
>
> With the above include added, these constants are now also defined
> in files that include hclge_err.h. Which leads to them
> being defined but unused in hclge_main.c.
>
> At a glance, it seems that these constants are only used in hclge_debugfs.c.
> Perhaps they could simply be moved there?
Yeah, I also plan to move them to hclge_debugfs.c.
So I'm going to add a patch to the v3 patchset to move them

Thanks,
Jijie