Re: [PATCH v2] tty: Add comments for tty-ldisc module loading logic

From: quic_zijuhu
Date: Fri Dec 15 2023 - 09:59:05 EST


On 12/15/2023 10:12 PM, Greg KH wrote:
> On Fri, Dec 15, 2023 at 09:41:30PM +0800, Zijun Hu wrote:
>> Current tty-ldisc module loading logic within tty_ldisc_get()
>> is prone to mislead beginner that the module is able to be loaded
>> by a user without capability CAP_SYS_MODULE, add comments to make
>> the logic easy to undertand.
>>
>> Signed-off-by: Zijun Hu <quic_zijuhu@xxxxxxxxxxx>
>> ---
>> Changes in v2:
>> - Remove condition checking changes
>
> As I asked for before, please get other, more experienced developers,
> from your company, to review and sign-off on this patch before sending
> it out again. I can't take this as-is, sorry.
>
okay
> greg k-h