Re: (subset) [PATCH] drm/imagination: Fixed infinite loop in pvr_vm_mips_map()

From: Maxime Ripard
Date: Fri Dec 15 2023 - 08:13:11 EST


On Fri, 08 Dec 2023 16:08:25 +0000, Donald Robson wrote:
> Unwinding loop in error path for this function uses unsigned limit
> variable, causing the promotion of the signed counter variable.
>
> --> 204 for (; pfn >= start_pfn; pfn--)
> ^^^^^^^^^^^^^^^^
> If start_pfn can be zero then this is an endless loop. I've seen this
> code in other places as well. This loop is slightly off as well. It
> should decrement pfn on the first iteration.
>
> [...]

Applied to drm/drm-misc (drm-misc-next-fixes).

Thanks!
Maxime