Re: [PATCH net] net: phy: skip LED triggers on PHYs on SFP modules

From: Andrew Lunn
Date: Fri Dec 15 2023 - 04:53:40 EST


On Thu, Dec 14, 2023 at 06:31:23PM -0800, Jakub Kicinski wrote:
> On Tue, 12 Dec 2023 00:05:35 +0000 Daniel Golle wrote:
> > Calling led_trigger_register() when attaching a PHY located on an SFP
> > module potentially (and practically) leads into a deadlock.
> > Fix this by not calling led_trigger_register() for PHYs localted on SFP
> > modules as such modules actually never got any LEDs.
>
> Any suggestion of a Fixes tag?
> Looks like the triggers were added a while back, are we only seeing it
> now because we started exercising the code more?

How about:

Fixes: 01e5b728e9e4 ("net: phy: Add a binding for PHY LEDs")

Andrew