Re: [PATCH v2 3/3] mailbox: mtk-cmdq: Add CMDQ driver support for mt8188

[CK Hu (胡俊光)]

On Fri, 2023-12-15 at 15:00 +0800, Jason-JH.Lin wrote:
> Add CMDQ driver support for mt8188 by adding its compatible and
> driver data in CMDQ driver.

Reviewed-by: CK Hu <ck.hu@xxxxxxxxxxxx>

> 
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@xxxxxxxxxxxx>
> ---
>  drivers/mailbox/mtk-cmdq-mailbox.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/mailbox/mtk-cmdq-mailbox.c
> b/drivers/mailbox/mtk-cmdq-mailbox.c
> index 39bf066d376e..27ff3a3ccf2f 100644
> --- a/drivers/mailbox/mtk-cmdq-mailbox.c
> +++ b/drivers/mailbox/mtk-cmdq-mailbox.c
> @@ -735,6 +735,13 @@ static const struct gce_plat gce_plat_mt8186 = {
>  	.gce_num = 1
>  };
>  
> +static const struct gce_plat gce_plat_mt8188 = {
> +	.thread_nr = 32,
> +	.shift = 3,
> +	.control_by_sw = true,
> +	.gce_num = 2
> +};
> +
>  static const struct gce_plat gce_plat_mt8192 = {
>  	.thread_nr = 24,
>  	.shift = 3,
> @@ -754,6 +761,7 @@ static const struct of_device_id cmdq_of_ids[] =
> {
>  	{.compatible = "mediatek,mt8173-gce", .data = (void
> *)&gce_plat_mt8173},
>  	{.compatible = "mediatek,mt8183-gce", .data = (void
> *)&gce_plat_mt8183},
>  	{.compatible = "mediatek,mt8186-gce", .data = (void
> *)&gce_plat_mt8186},
> +	{.compatible = "mediatek,mt8188-gce", .data = (void
> *)&gce_plat_mt8188},
>  	{.compatible = "mediatek,mt8192-gce", .data = (void
> *)&gce_plat_mt8192},
>  	{.compatible = "mediatek,mt8195-gce", .data = (void
> *)&gce_plat_mt8195},
>  	{}