Re: [PATCH v1 1/6] gpiolib: acpi: Modify acpi_dev_irq_wake_get_by to use resource

From: Mark Hasemeyer
Date: Thu Dec 14 2023 - 15:57:26 EST


> > + *r = (struct resource)DEFINE_RES_IRQ(irq);
>
> Why do you need "(struct resource)" annotation?

I don't. I originally started working on this patch on a kernel
version that didn't have 52c4d11f1dce ("resource: Convert
DEFINE_RES_NAMED() to be compound literal").

> > + struct resource irqres;
> > struct i2c_acpi_irq_context irq_ctx = {
> > .irq = -ENOENT,
> > };
>
> Hmm... I'm wondering if we can reuse irqres as a context to the respective
> lookup calls.

I'll see if I can safely remove it.