Re: [PATCH v7 14/24] x86/resctrl: Allow resctrl_arch_rmid_read() to sleep

From: Reinette Chatre
Date: Thu Dec 14 2023 - 13:54:43 EST


Hi James,

On 12/14/2023 3:37 AM, James Morse wrote:
> On 09/11/2023 17:47, Reinette Chatre wrote:
>> On 10/25/2023 11:03 AM, James Morse wrote:

>>>
>>> No changes since v6
>>
>> If I trusted this I would not have taken the time to review this patch.
>
> I'm not sure what you want me to do from this comment ... but this 'no changes' annotation
> doesn't work for either of us, so I'll remove them.
>

The "no changes" annotation is valuable when it is accurate. When the patch
explicitly claims to have no changes since previous version when in fact there
are changes then it complicates the review process.

Reinette