Re: [PATCH] Revert "soc: qcom: stats: Add DDR sleep stats"

From: Doug Anderson
Date: Thu Dec 14 2023 - 12:48:49 EST


Hi,

On Thu, Dec 14, 2023 at 4:25 AM Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> wrote:
>
> After recent reports ([1], [2]) of older platforms (particularly 8150 and
> 7180) breaking after DDR sleep stats introduction, revert the following:
>
> Commit 73380e2573c3 ("soc: qcom: stats: fix 64-bit division")
> Commit e84e61bdb97c ("soc: qcom: stats: Add DDR sleep stats")
>
> The feature itself is rather useful for debugging DRAM power management,
> however it looks like the shared RPMh stats data structures differ on
> previous SoCs.
>
> Revert its addition for now to un-break booting on these earlier SoCs,
> while I try to come up with a better way to enable it conditionally.
>
> [1] https://lore.kernel.org/linux-arm-msm/20231209215601.3543895-2-dmitry.baryshkov@xxxxxxxxxx/
> [2] https://lore.kernel.org/linux-arm-msm/CAD=FV=XX4wLg1NNVL15RK4D4tLvuSzZyUv=k_tS4bSb3=7QJzQ@xxxxxxxxxxxxxx/
>
> Reported-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Reported-by: Doug Anderson <dianders@xxxxxxxxxxxx>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
> ---
> drivers/soc/qcom/qcom_stats.c | 187 +-----------------------------------------
> 1 file changed, 1 insertion(+), 186 deletions(-)

Tested-by: Douglas Anderson <dianders@xxxxxxxxxxxx>