On 12-12-23, 19:58, Harald Mommer wrote:
On 12.12.23 11:34, Viresh Kumar wrote:I hope you are talking about V8/V9 of the spec here, as I only see one
I'm working on V8. It's coming to an end, will still have to check some
details but it's close. Internal review pending. Now there is a V9 and I
will also have to look at this. Maybe I will send V8 and subsequently update
to V9,
version of the Linux driver on the list. Please keep me in cc if
possible.
Looked at all headers for SPDX License in include/uapi/ and this isOn 27-10-23, 18:10, Harald Mommer wrote:Looking into what others do here. virtio_blk.h, virtio_input.h and
+++ b/include/uapi/linux/virtio_spi.hMaybe this should be:
@@ -0,0 +1,130 @@
+/* SPDX-License-Identifier: BSD-3-Clause */
SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause
?
virtio_iommu.h for example: None is using GPL-2.0 here. virtio_iommu.h is
using exactly the same header as we do.
what I see (Yes there are many non SPDX licenses there):
522 /* SPDX-License-Identifier: GPL-2.0 WITH Linux-syscall-note */
106 /* SPDX-License-Identifier: GPL-2.0+ WITH Linux-syscall-note */
18 /* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause) */
16 /* SPDX-License-Identifier: LGPL-2.1+ WITH Linux-syscall-note */
16 /* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note */
11 /* SPDX-License-Identifier: GPL-1.0+ WITH Linux-syscall-note */
6 /* SPDX-License-Identifier: ((GPL-2.0-only WITH Linux-syscall-note) OR BSD-3-Clause) */
5 /* SPDX-License-Identifier: BSD-3-Clause */
4 /* SPDX-License-Identifier: LGPL-2.1 WITH Linux-syscall-note */
4 /* SPDX-License-Identifier: LGPL-2.0+ WITH Linux-syscall-note */
4 /* SPDX-License-Identifier: ((GPL-2.0+ WITH Linux-syscall-note) OR BSD-3-Clause) */
3 /* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR MIT */
2 /* SPDX-License-Identifier: MIT */
2 /* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR Linux-OpenIB) */
2 /* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR CDDL-1.0) */
2 /* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR BSD-2-Clause) */
2 /* SPDX-License-Identifier: GPL-2.0-or-later WITH Linux-syscall-note */
1 /* SPDX-License-Identifier: ((GPL-2.0+ WITH Linux-syscall-note) OR MIT) */
1 /* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) OR BSD-3-Clause */
1 /* SPDX-License-Identifier: (GPL-2.0 WITH Linux-syscall-note) */
1 /* SPDX-License-Identifier: GPL-2.0-only WITH Linux-syscall-note*/
Also Documentation/process/license-rules.rst says:
"The license described in the COPYING file applies to the kernel source
as a whole, though individual source files can have a different license
which is required to be compatible with the GPL-2.0::
...
Aside from that, individual files can be provided under a dual license,
e.g. one of the compatible GPL variants and alternatively under a
permissive license like BSD, MIT etc."
And so I thought we may want this to be a dual license.
V8 of this patch ?Checking my current code. This is updated in the V8 version.+/* All config fields are read-only for the Virtio SPI driver */Can you please add proper doc style comments for the structures ?
+struct virtio_spi_config {