Re: [PATCH net-next] dt-bindings: net: marvell,orion-mdio: Drop "reg" sizes schema

From: Conor Dooley
Date: Thu Dec 14 2023 - 11:23:57 EST


On Wed, Dec 13, 2023 at 05:24:55PM -0600, Rob Herring wrote:
> Defining the size of register regions is not really in scope of what
> bindings need to cover. The schema for this is also not completely correct
> as a reg entry can be variable number of cells for the address and size,
> but the schema assumes 1 cell.
>
> Signed-off-by: Rob Herring <robh@xxxxxxxxxx>

Does this not also remove restrictions on what the number in the reg
entry is actually allowed to be?

> ---
> .../bindings/net/marvell,orion-mdio.yaml | 22 -------------------
> 1 file changed, 22 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> index e35da8b01dc2..73429855d584 100644
> --- a/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> +++ b/Documentation/devicetree/bindings/net/marvell,orion-mdio.yaml
> @@ -39,28 +39,6 @@ required:
> allOf:
> - $ref: mdio.yaml#
>
> - - if:
> - required:
> - - interrupts
> -
> - then:
> - properties:
> - reg:
> - items:
> - - items:
> - - $ref: /schemas/types.yaml#/definitions/cell
> - - const: 0x84
> -
> - else:
> - properties:
> - reg:
> - items:
> - - items:
> - - $ref: /schemas/types.yaml#/definitions/cell
> - - enum:
> - - 0x4
> - - 0x10
> -
> unevaluatedProperties: false
>
> examples:
> --
> 2.43.0
>

Attachment: signature.asc
Description: PGP signature