Re: [PATCH v10 09/19] KVM: xen: separate initialization of shared_info cache and content

[Paul Durrant]

On 14/12/2023 13:41, David Woodhouse wrote:
> On Mon, 2023-12-04 at 14:43 +0000, Paul Durrant wrote:
> > From: Paul Durrant <pdurrant@xxxxxxxxxx>
> >
> > A subsequent patch will allow shared_info to be initialized using either a
> > GPA or a user-space (i.e. VMM) HVA. To make that patch cleaner, separate
> > the initialization of the shared_info content from the activation of the
> > pfncache.
> >
> > Signed-off-by: Paul Durrant <pdurrant@xxxxxxxxxx>
>
>
> Spot the difference...
>   
> > -               /*
> > -                * This code mirrors kvm_write_wall_clock() except that it writes
> > -                * directly through the pfn cache and doesn't mark the page dirty.
> > -                */
> > -               wall_nsec = kvm_get_wall_clock_epoch(kvm);
>
>
> > +       /*
> > +        * This code mirrors kvm_write_wall_clock() except that it writes
> > +        * directly through the pfn cache and doesn't mark the page dirty.
> > +        */
> > +       wall_nsec = ktime_get_real_ns() - get_kvmclock_ns(kvm);
>
> (Hint: it's commit 5d6d6a7d7e66a)

Ack.

> With that fixed,
>
> Reviewed-by: David Woodhouse <dwmw@xxxxxxxxxxxx>

Thanks.