RE: [PATCH net-next v14 01/13] rtase: Add pci table supported in this module

[JustinLai0215]

> -----Original Message-----
> From: Paolo Abeni <pabeni@xxxxxxxxxx>
> Sent: Tuesday, December 12, 2023 5:36 PM
> To: JustinLai0215 <justinlai0215@xxxxxxxxxxx>; kuba@xxxxxxxxxx
> Cc: davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> linux-kernel@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; andrew@xxxxxxx;
> Ping-Ke Shih <pkshih@xxxxxxxxxxx>; Larry Chiu <larry.chiu@xxxxxxxxxxx>
> Subject: Re: [PATCH net-next v14 01/13] rtase: Add pci table supported in this
> module
> 
> 
> External mail.
> 
> 
> 
> On Fri, 2023-12-08 at 17:47 +0800, Justin Lai wrote:
> [...]
> > +static void rtase_remove_one(struct pci_dev *pdev) {
> > +     struct net_device *dev = pci_get_drvdata(pdev);
> > +     struct rtase_private *tp = netdev_priv(dev);
> > +     struct rtase_int_vector *ivec;
> > +     u32 i;
> > +
> > +     for (i = 0; i < tp->int_nums; i++) {
> > +             ivec = &tp->int_vector[i];
> > +             netif_napi_del(&ivec->napi);
> > +     }
> 
> You must unregister the netdev before napi_del or you will risk races.

Ok, Thank you for your suggestion.

> 
> Cheers,
> 
> Paolo