Re: [PATCH] media: dt-bindings: samsung,s5p-mfc: Fix iommu properties schemas

[Krzysztof Kozlowski]

On 13/12/2023 23:42, Rob Herring wrote:
> The iommus and iommu-names property schemas have several issues. First,
> 'iommus-names' in the if/then schemas is the wrong name. As all the names
> are the same, they can be defined at the top level instead. Then the
> if/then schemas just need to define how many entries. The iommus if/then
> schemas are also redundant. Best I can tell, the desire was to require 2
> entries for "samsung,exynos5433-mfc", "samsung,mfc-v5", "samsung,mfc-v6",
> and "samsung,mfc-v8".
> 

...

> -        iommus-names: false
> +        iommu-names: false
>  
>    - if:
>        properties:
> @@ -102,11 +104,9 @@ allOf:
>              - const: aclk
>              - const: aclk_xiu
>          iommus:
> -          maxItems: 2
> -        iommus-names:
> -          items:
> -            - const: left
> -            - const: right
> +          minItems: 2
> +        iommu-names:
> +          minItems: 2
>  
>    - if:
>        properties:
> @@ -123,11 +123,9 @@ allOf:
>              - const: mfc
>              - const: sclk_mfc
>          iommus:
> -          maxItems: 2
> +          minItems: 2
>          iommus-names:

Also here -> iommu-names

> -          items:
> -            - const: left
> -            - const: right
> +          minItems: 2
>  
>    - if:
>        properties:
> @@ -144,11 +142,9 @@ allOf:
>            items:
>              - const: mfc
>          iommus:
> -          maxItems: 2
> +          minItems: 2
>          iommus-names:

Also here

> -          items:
> -            - const: left
> -            - const: right
> +          minItems: 2
>  
Best regards,
Krzysztof