Re: [PATCH] net: dsa: vsc73xx: Add null pointer check to vsc73xx_gpio_probe

[Kunwu Chan]

Thanks for your reply.

I'll remove 'dev_err' in v2 patch.

Thanks again.

On 2023/12/13 05:27, Jakub Kicinski wrote:
> On Mon, 11 Dec 2023 10:45:49 +0800 Kunwu Chan wrote:
> >   	vsc->gc.label = devm_kasprintf(vsc->dev, GFP_KERNEL, "VSC%04x",
> >   				       vsc->chipid);
> > +	if (!vsc->gc.label) {
> > +		dev_err(vsc->dev, "Fail to allocate memory\n");
> > +		return -ENOMEM;
> > +	}
>
> Don't add error prints on memory allocations.
> There will be an OOM splat in the logs.