RE: [PATCH] pci: rcar-gen4: Replace of_device.h with explicit of.h include

From: Yoshihiro Shimoda
Date: Wed Dec 13 2023 - 21:28:20 EST


Hello,

> From: Krzysztof Wilczyński, Sent: Thursday, December 14, 2023 10:33 AM
>
> Hello,
>
> > The DT of_device.h and of_platform.h date back to the separate
> > of_platform_bus_type before it was merged into the regular platform bus.
> > As part of that merge prepping Arm DT support 13 years ago, they
> > "temporarily" include each other. They also include platform_device.h
> > and of.h. As a result, there's a pretty much random mix of those include
> > files used throughout the tree. In order to detangle these headers and
> > replace the implicit includes with struct declarations, users need to
> > explicitly include the correct includes.
>
> Applied to controller/rcar, thank you!
>
> [1/1] PCI: rcar-gen4: Replace of_device.h with explicit of.h include
>
> https://git.kernel.org/pub/scm/linux/kernel/git/pci/pci.git/commit/?id=263714f5fcf8

Thank you! I completely overlooked this patch. Maybe it's too late, but I also reviewed this patch, so

Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>

It's up to you whether my tag is added to the commit or not :)

Best regards,
Yoshihiro Shimoda

> Krzysztof