Re: [PATCH v1 00/14] Clean up libperf cpumap's empty function

From: Namhyung Kim
Date: Wed Dec 13 2023 - 18:29:39 EST


On Tue, Nov 28, 2023 at 10:02 PM Ian Rogers <irogers@xxxxxxxxxx> wrote:
>
> Rename and clean up the use of libperf CPU map functions particularly
> focussing on perf_cpu_map__empty that may return true for maps
> containing CPUs but also with an "any CPU"/dummy value.
>
> perf_cpu_map__nr is also troubling in that iterating an empty CPU map
> will yield the "any CPU"/dummy value. Reduce the appearance of some
> calls to this by using the perf_cpu_map__for_each_cpu macro.
>
> Ian Rogers (14):
> libperf cpumap: Rename perf_cpu_map__dummy_new
> libperf cpumap: Rename and prefer sysfs for perf_cpu_map__default_new
> libperf cpumap: Rename perf_cpu_map__empty
> libperf cpumap: Replace usage of perf_cpu_map__new(NULL)
> libperf cpumap: Add for_each_cpu that skips the "any CPU" case
> libperf cpumap: Add any, empty and min helpers
> perf arm-spe/cs-etm: Directly iterate CPU maps
> perf intel-pt/intel-bts: Switch perf_cpu_map__has_any_cpu_or_is_empty
> use
> perf cpumap: Clean up use of perf_cpu_map__has_any_cpu_or_is_empty
> perf top: Avoid repeated function calls
> perf arm64 header: Remove unnecessary CPU map get and put
> perf stat: Remove duplicate cpus_map_matched function
> perf cpumap: Use perf_cpu_map__for_each_cpu when possible
> libperf cpumap: Document perf_cpu_map__nr's behavior

Acked-by: Namhyung Kim <namhyung@xxxxxxxxxx>

Thanks,
Namhyung