Re: [PATCH 2/3] usb: xhci-mtk: fix a short packet issue of gen1 isoc-in transfer
From: kernel test robot
Date: Wed Dec 13 2023 - 16:04:27 EST
Hi Chunfeng,
kernel test robot noticed the following build errors:
[auto build test ERROR on usb/usb-testing]
[also build test ERROR on usb/usb-next usb/usb-linus robh/for-next krzk/for-next linus/master v6.7-rc5 next-20231213]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chunfeng-Yun/usb-xhci-mtk-fix-a-short-packet-issue-of-gen1-isoc-in-transfer/20231213-143959
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20231213063543.12435-2-chunfeng.yun%40mediatek.com
patch subject: [PATCH 2/3] usb: xhci-mtk: fix a short packet issue of gen1 isoc-in transfer
config: arm-randconfig-001-20231213 (https://download.01.org/0day-ci/archive/20231214/202312140415.r09Wbh8D-lkp@xxxxxxxxx/config)
compiler: clang version 17.0.0 (https://github.com/llvm/llvm-project.git 4a5ac14ee968ff0ad5d2cc1ffa0299048db4c88a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231214/202312140415.r09Wbh8D-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312140415.r09Wbh8D-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
>> drivers/usb/host/xhci-mtk.c:184:12: error: call to undeclared function 'FIELD_PREP'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
184 | value |= FIELD_PREP(SCH3_RXFIFO_DEPTH_MASK, 2);
| ^
1 error generated.
vim +/FIELD_PREP +184 drivers/usb/host/xhci-mtk.c
170
171 /*
172 * workaround: usb3.2 gen1 isoc rx hw issue
173 * host send out unexpected ACK afer device fininsh a burst transfer with
174 * a short packet.
175 */
176 static void xhci_mtk_rxfifo_depth_set(struct xhci_hcd_mtk *mtk)
177 {
178 struct usb_hcd *hcd = mtk->hcd;
179 u32 value;
180
181 if (mtk->rxfifo_depth_quirk) {
182 value = readl(hcd->regs + HSCH_CFG1);
183 value &= ~SCH3_RXFIFO_DEPTH_MASK;
> 184 value |= FIELD_PREP(SCH3_RXFIFO_DEPTH_MASK, 2);
185 writel(value, hcd->regs + HSCH_CFG1);
186 }
187 }
188
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki