Re: [PATCH] x86: tdx: hide unused tdx_dump_mce_info()

[Huang, Kai]

On Wed, 2023-12-13 at 15:02 +0300, Kirill A. Shutemov wrote:
> On Tue, Dec 12, 2023 at 01:42:09PM -0800, Dave Hansen wrote:
> > On 12/12/23 13:36, Arnd Bergmann wrote:
> > > From: Arnd Bergmann <arnd@xxxxxxxx>
> > > 
> > > When TDX is enabled but MCE is not, the tdx_dump_mce_info() function
> > > fails to link:
> > 
> > Thanks for the report, Arnd.
> > 
> > The only way that TDX has to report integrity errors is an MCE.  I'm not
> > sure it even makes sense to have TDX support but not MCE support.  Maybe
> > we should just make TDX host support depend on MCE.
> 
> I agree. Silently ignore integrity errors is not good idea.
> 
> TDX module spec also supports it:
> 
> "The machine-check exception handler is expected to be implemented in the
> VMM."

I also agree.  Thanks.