Re: [PATCH v1 3/6] of: irq: add wake capable bit to of_irq_resource()
From: Andy Shevchenko
Date: Wed Dec 13 2023 - 14:44:29 EST
On Wed, Dec 13, 2023 at 11:00:21AM -0700, Mark Hasemeyer wrote:
> Add wake capability information to the irq resource. Wake capability is
IRQ
> assumed based on conventions provided in the devicetree wakeup-source
> binding documentation. An interrupt is considered wake capable if the
> following are true:
> 1. a wakeup-source property exits in the same device node as the
> interrupt.
> 2. No dedicated irq is defined, or the irq is marked as dedicated by
IRQ
> setting its interrupt-name to "wakeup".
>
> The wakeup-source documentation states that dedicated interrupts can use
> device specific interrupt names and device drivers are still welcome to
> use their own naming schemes. This api is provided as a helper if one is
API
> willing to conform to the above conventions.
>
> The ACPI subsystems already provides similar apis that allow one to
APIs
> query the wake capability of an irq. This brings feature parity to the
> devicetree.
...
> +/**
> + * __of_irq_wake_capable - Determine whether a given irq index is wake capable
IRQ
> + * The irq is considered wake capable if the following are true:
IRQ
> + * 1. wakeup-source property exists
> + * 2. no dedicated wakeirq exists OR provided irq index is a dedicated wakeirq
IRQ
> + * This logic assumes the provided irq index is valid.
IRQ
> + * @dev: pointer to device tree node
> + * @index: zero-based index of the irq
IRQ
> + * Return: True if provided irq index for #dev is wake capable. False otherwise.
IRQ
@dev
> + */
...
> /**
> * of_irq_to_resource - Decode a node's IRQ and return it as a resource
> * @dev: pointer to device tree node
> * @index: zero-based index of the irq
> * @r: pointer to resource structure to return result into.
> + *
> + * Return: Linux IRQ number on success, or 0 on the IRQ mapping failure, or
> + * -EPROBE_DEFER if the IRQ domain is not yet created, or error code in case
> + * of any other failure.
> */
You see, your new text is even inconsistent with the existing one...
--
With Best Regards,
Andy Shevchenko