Re: [PATCH 3/6] wifi: ath10k: remove struct wmi_pdev_chanlist_update_event

From: Kees Cook
Date: Wed Dec 13 2023 - 14:12:18 EST


On Wed, Dec 13, 2023 at 09:06:41AM -0800, Jeff Johnson wrote:
> Currently struct wmi_pdev_chanlist_update_event defines:
> struct wmi_channel channel_list[1];
>
> Per the guidance in [1] this should be a flexible array. However
> during conversion it was discovered that this struct is not used, so
> just remove the entire struct.
>
> No functional changes, compile tested only.
>
> [1] https://docs.kernel.org/process/deprecated.html#zero-length-and-one-element-arrays
>
> Signed-off-by: Jeff Johnson <quic_jjohnson@xxxxxxxxxxx>

Removal of unused structs is good. :)

Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>

--
Kees Cook