Re: [PATCH 01/10] dt-bindings: pinctrl: qcom: create common LPASS LPI schema

From: Rob Herring
Date: Wed Dec 13 2023 - 13:40:25 EST



On Fri, 08 Dec 2023 22:55:25 +0100, Krzysztof Kozlowski wrote:
> Just like regular TLMM pin controllers in Qualcomm SoCs, the Low Power
> Audio SubSystem (LPASS) Low Power Island (LPI) TLMM blocks share a lot
> of properties, so common part can be moved to separate schema to reduce
> code duplication and make reviewing easier.
>
> Except the move of common part, this introduces effective changes:
> 1. To all LPASS LPI bindings: Reference pinmux-node.yaml in each pin
> muxing and configuration node, to bring definition of "function" and
> "pins" properties.
>
> 2. qcom,sc7280-lpass-lpi-pinctrl: Reference pinctrl.yaml in top leve.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../pinctrl/qcom,lpass-lpi-common.yaml | 75 +++++++++++++++++++
> .../qcom,sc7280-lpass-lpi-pinctrl.yaml | 49 ++----------
> .../qcom,sc8280xp-lpass-lpi-pinctrl.yaml | 49 +-----------
> .../qcom,sm6115-lpass-lpi-pinctrl.yaml | 48 +-----------
> .../qcom,sm8250-lpass-lpi-pinctrl.yaml | 49 +-----------
> .../qcom,sm8350-lpass-lpi-pinctrl.yaml | 49 +-----------
> .../qcom,sm8450-lpass-lpi-pinctrl.yaml | 49 +-----------
> .../qcom,sm8550-lpass-lpi-pinctrl.yaml | 49 +-----------
> .../qcom,sm8650-lpass-lpi-pinctrl.yaml | 49 +-----------
> 9 files changed, 109 insertions(+), 357 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/pinctrl/qcom,lpass-lpi-common.yaml
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>