Re: [PATCH v6 22/40] ata: pata_ep93xx: add device tree support
From: Andy Shevchenko
Date: Wed Dec 13 2023 - 13:19:56 EST
On Tue, Dec 12, 2023 at 11:20:39AM +0300, Nikita Shubin wrote:
> - add OF ID match table
> - drop platform DMA and filters
> - change DMA setup to OF, so we can defer probe
...
> + drv_data->dma_rx_channel = dma_request_chan(dev, "rx");
> + if (IS_ERR(drv_data->dma_rx_channel)) {
> + ret = PTR_ERR(drv_data->dma_rx_channel);
> + return dev_err_probe(dev, ret, "rx DMA setup failed");
> + }
See the comments to other patches about PTR_ERR_OR_ZERO() use and
returning dev_err_probe().
...
> + drv_data->dma_tx_channel = dma_request_chan(&pdev->dev, "tx");
> + if (IS_ERR(drv_data->dma_tx_channel)) {
> + ret = PTR_ERR(drv_data->dma_tx_channel);
> + dev_err_probe(dev, ret, "tx DMA setup failed");
> + goto fail_release_rx;
> }
Ditto.
...
Seems like broken rebase or so as some of the latter changes in this file
should be done here.
--
With Best Regards,
Andy Shevchenko